Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get fullscreen working correctly in Safari #6

Closed
OscarGodson opened this issue Feb 18, 2012 · 7 comments
Closed

Get fullscreen working correctly in Safari #6

OscarGodson opened this issue Feb 18, 2012 · 7 comments
Assignees
@dadambickford
Labels
0.2.0 Bug QA'd
Milestone
1.0

Comments

@OscarGodson
Copy link
Owner

It's pretty buggy right now for some reason:

  • Full screen doesn't actually fit fullscreen
  • Closing fullscreen has a weird flash of an unstyled editor.
@ghost ghost assigned dadambickford Feb 23, 2012
@OscarGodson OscarGodson mentioned this issue Mar 12, 2012
Closed
@dadambickford
Copy link
Collaborator

Also just noticed, in safari, that if you try going to fullscreen, and then revert back. all of the sudden the util bar will not show up, and even the keyboard shortcuts will not change between preview/editor anymore.

@OscarGodson
Copy link
Owner Author

Yeah, the utilbar and stuff is still broken going back on all browsers. If you can just get it looking ok in fullscreen all the reverting will look fine once im done with it unless you want to take a stab at the reverting of styles.

@dadambickford
Copy link
Collaborator

alright, yeah i was going to try and get this one knocked out today. we'll see how it goes.

@OscarGodson
Copy link
Owner Author

Now this happens after i close fullscreen once. To get true fullscreen i have to totally quit Safari and reopen it. WTF?!

safari is fucked

@OscarGodson OscarGodson mentioned this issue Mar 22, 2012
Closed
@OscarGodson
Copy link
Owner Author

I'm going to check for Safari in 0.1.2 and have it use the faux fullscreen since getting real fullscreen to work seems to be too hard.

OscarGodson added a commit that referenced this issue Jul 24, 2012
@OscarGodson
Ticket #6 - Shitty patch for Safari fullscreen. Using faux fullscreen…
a0b2eab 
… until Safari gets fixed
@OscarGodson
Copy link
Owner Author

have the nasty fix in there for now. We'll need to open a new ticket if Safari ever gets fixed

hongymagic added a commit to hongymagic/EpicEditor that referenced this issue Jul 29, 2012
@hongymagic
Merge remote-tracking branch 'upstream/develop' into feature/newline
1baef1a 
* upstream/develop:
  Ticket OscarGodson#96 - Make hash links scroll the iframe, not open a new browser window
  Ticket OscarGodson#6 - Shitty patch for Safari fullscreen. Using faux fullscreen until Safari gets fixed
  Prevent loading the editor when it's already loaded
  Typo in comment
  Ticket OscarGodson#161 - Remember the edit or preview state on unloading so when you load again its where you left it. Also added a guard for calling load when its already loaded to save on memory and changed all _eeState checks internally to use is() instead
  Ticket OscarGodson#88 - Added public is() method to check the state of EE. Added docs and tests and changed eeState to _eeState

Conflicts:
	epiceditor/js/epiceditor.js
	epiceditor/js/epiceditor.min.js
	src/editor.js
@OscarGodson
Copy link
Owner Author

Tested on Safari 6. Still works like shit... Updated the comment.

OscarGodson added a commit that referenced this issue Oct 14, 2012
@OscarGodson
Ticket #6 - Yes. Safari 6's Fullscreen API still doesn't work like ev…
5e261e4 
…eryone elses, so update the comment to recheck when Safari 7 comes out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadambickford dadambickford

Labels
0.2.0 Bug QA'd
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@OscarGodson @dadambickford