Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making UI strings configurable / providing alternative icons #192

Closed
wants to merge 4 commits into from
Closed

Conversation

cmtt
Copy link

@cmtt cmtt commented Dec 2, 2012

This could be useful for i18n purposes.

@OscarGodson
Copy link
Owner

Great idea! Anyway you can submit this without all the whitespace changes? :)

@cmtt
Copy link
Author

cmtt commented Dec 16, 2012

In addition, this pull request includes now alternative hand-drawn icons.

@OscarGodson
Copy link
Owner

Hey @cmtt - I want you to be able to be listed as a contributor on the https://github.com/OscarGodson/EpicEditor/graphs/contributors page, but right now there's a bunch of other commits. The sketch icons are nice but those would be part of a theme or something, not the core plus I dont want this package to grow too large. If you want to be listed there could you post a new pull request with just your UI string commit and without the whitespace changes?

If you don't care I'll just make the change.

@cmtt
Copy link
Author

cmtt commented Jan 8, 2013

This is surely reasonable, I should have had committed the icons in a seperate pull request.
Eventually, the original changes are re-submitted in #199 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants