Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for nwdFracLut test #567

Merged
merged 10 commits into from
Dec 19, 2019
Merged

Updates for nwdFracLut test #567

merged 10 commits into from
Dec 19, 2019

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Dec 19, 2019

Closes #539
Resolves #535

This PR fixes the issues that I discussed in #535 (comment) that were causing the nwdFracLut test to fail.

Copy link
Collaborator

@taylor13 taylor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that you went with option 2: Look at all string dimensions and define "strlen" to be maximum length of all values? If so and if

  1. it passes the test suite, and
  2. it works for the case causing problems
    Then I think we can approve.

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Dec 19, 2019

@taylor13 The NetCDF dimension "strlen" will get defined with the greatest string length of all string axes and singletons if a string axis is found in the function cmor_define_dimensions. If it is not defined in that function, then "strlen" will be defined with the greatest string length of all string singletons in the function create_singleton_dimensions.

@taylor13
Copy link
Collaborator

sounds good to me.

@mauzey1 mauzey1 merged commit 7c252cc into master Dec 19, 2019
@mauzey1 mauzey1 deleted the pull_539 branch December 19, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nwdFracLut in Emon
2 participants