-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for nwdFracLut test #567
Conversation
…length of the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct that you went with option 2: Look at all string dimensions and define "strlen" to be maximum length of all values? If so and if
- it passes the test suite, and
- it works for the case causing problems
Then I think we can approve.
@taylor13 The NetCDF dimension "strlen" will get defined with the greatest string length of all string axes and singletons if a string axis is found in the function |
sounds good to me. |
Closes #539
Resolves #535
This PR fixes the issues that I discussed in #535 (comment) that were causing the nwdFracLut test to fail.