Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #37

Merged
merged 4 commits into from
Aug 16, 2017
Merged

Documentation updates #37

merged 4 commits into from
Aug 16, 2017

Conversation

frenck
Copy link
Contributor

@frenck frenck commented Aug 16, 2017

Proposed Changes

Updated some aspects of the documentation.

  • Add: Example project to show how it works when using multiple standards
  • Change: all URL's related to our company website/vacancies.
  • Change: Minor typo and punctuation fixes.

Related Issues

#36 Update README.md

@frenck frenck added this to the v0.4.2 milestone Aug 16, 2017
@frenck frenck self-assigned this Aug 16, 2017
@frenck frenck requested a review from Potherca August 16, 2017 10:07
README.md Outdated
"dealerdirect/phpcodesniffer-composer-installer": "*",
"wimg/php-compatibility": "*",
"wp-coding-standards/wpcs": "*",
"object-calisthenics/phpcs-calisthenics-rules": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest placing the requirements in alphabetical order, specifically because "config": {"sort-packages": true} is becoming more and more popular

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted. I have left out the configuration, since that is not in scope of the example ;)

Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion for improvement. Other than that looks good.

@frenck frenck merged commit 17130f5 into master Aug 16, 2017
@frenck frenck deleted the documentation-updates branch August 16, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants