Proceed Performer Element Changes #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e height as the laptop icon
…he engine and for versioning
…d in an incomplete state when it is loaded into the modeler
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…added coloring functions for resources
… the label resetting it to using the outline color of the resource
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FelipeTrost
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Everything looks good, however when modeling there are uncaught errors when I do the following
- Drag the association endpoints of a generic resource:
unhandled error in event listener Error: no shape type specified - Copy and paste a generic resource:
Error: <bpmn:Association id="Association_0obxd0t" />#source Ref not specified
I also think that image export function getSVGFromBPMN is missing the new modules, such that exported images won't work properly.
Comment on lines
215
to
216
| } else { | ||
| } |
|
I fixed the errors |
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to: #468
Changed the way the performers are saved in the bpmn and added some quality of life modeling improvements for performer elements
Details
proceed:Performertoproceed:genericResourceproceed:genericResourcetype with theresourceTypeattributes to differentiate between the different visualisations instead of splitting the resources intoproceed:HumanPerformerandproceed:MachinePerformer