fix(ms2/modeler): check selected id to avoid unwanted buttons with current root #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeTrost
had a problem deploying
to
Research
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug Fix: after opening a collapsed subprocess with the button
Open subprocess, the button does not automatically disappear if inside the subprocessThis happens because when there is no element selected we take the root, for the case of a collapsed process the root is a subprocess which results in the button being displayed.
The fix is to check if there also is a selectedId, so that we can be sure, that the user actually selected an element.
closes #473