Skip to content

Commit

Permalink
mc_att_control_main: do not apply the yaw weight for the feedforward …
Browse files Browse the repository at this point in the history
…term

The meaning of the yaw weight changed with #8003:
- before, the yaw weight decreased with increasing tilt angle error, so
  it was mostly 1
- now, it is constant and depends on the tuning gains (around 0.4 by default)

It means that #8003 reduced the feedforward term, and we get the closer
behavior as before with this change.
It also reduces coupling between different parameters.
  • Loading branch information
bkueng authored and LorenzMeier committed Apr 25, 2018
1 parent 202505f commit 332a612
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/modules/mc_att_control/mc_att_control_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ MulticopterAttitudeControl::control_attitude(float dt)
* because it's the rotation axis for body yaw and multiply it by the rate and gain. */
Vector3f yaw_feedforward_rate = q.inversed().dcm_z();
yaw_feedforward_rate *= _v_att_sp.yaw_sp_move_rate * _yaw_ff.get();
yaw_feedforward_rate(2) *= yaw_w;
_rates_sp += yaw_feedforward_rate;


Expand Down

0 comments on commit 332a612

Please sign in to comment.