-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: lis3mdl with two sensors not working #10748
Conversation
Awesome, thanks! |
Note: This also fixes PREFLIGHT FAIL: MAG 1 SELFTEST FAILED in QGroundControl. Might be there are other modules with the same problem. While searching for the problem, I found some reports about this but without a solution. By the way: I had also PREFLIGHT FAIL: MAG SENSORS INCONSISTENT at the beginning, but the https://store.mrobotics.io/mRo-GPS-u-Blox-Neo-M8N-HMC5983-Compass-p/mro-gps003-mr.htm needs Yaw 90°. Just found it by comparing my mobile phone's compass with the compass in QGroundControl. |
This needs to be merged into master. I'll update the PR base. |
This doesn't apply cleanly to master. @hdiethelm could you rebase your commit to master and either change the pull request or open a new one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR needs to go into master, not stable.
Just did a pull request for the master branch and squashed the tree commits in one. Someone knows how to change both "into" and "from" for a pull request? |
Fix for #10740
lis3mdl was not initializing multiple sensors properly when started using:
lis3mdl start
The second sensor was just initialized but not started and there where some other bugs which where not visible at first glance.
Now, lis3mdl does the actions for all sensors when not called with -I, -X or -S.
I tested all commands with no argument, -X and -S. I was not able to test -I because I don't have an internal I2C sensor.
test_log.txt