Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: lis3mdl with two sensors not working #10748

Closed
wants to merge 3 commits into from
Closed

Conversation

hdiethelm
Copy link

@hdiethelm hdiethelm commented Oct 23, 2018

Fix for #10740

lis3mdl was not initializing multiple sensors properly when started using:
lis3mdl start
The second sensor was just initialized but not started and there where some other bugs which where not visible at first glance.

Now, lis3mdl does the actions for all sensors when not called with -I, -X or -S.

I tested all commands with no argument, -X and -S. I was not able to test -I because I don't have an internal I2C sensor.

test_log.txt

@hdiethelm hdiethelm changed the title Fix: lis3mdl with two sensors not working #10740 Fix: lis3mdl with two sensors not working Oct 23, 2018
@LorenzMeier
Copy link
Member

Awesome, thanks!

@hdiethelm
Copy link
Author

Note: This also fixes PREFLIGHT FAIL: MAG 1 SELFTEST FAILED in QGroundControl.

Might be there are other modules with the same problem. While searching for the problem, I found some reports about this but without a solution.

By the way: I had also PREFLIGHT FAIL: MAG SENSORS INCONSISTENT at the beginning, but the https://store.mrobotics.io/mRo-GPS-u-Blox-Neo-M8N-HMC5983-Compass-p/mro-gps003-mr.htm needs Yaw 90°. Just found it by comparing my mobile phone's compass with the compass in QGroundControl.

@dagar dagar requested a review from dakejahl October 24, 2018 14:26
@dagar dagar added the bug label Oct 24, 2018
@dagar
Copy link
Member

dagar commented Oct 24, 2018

This needs to be merged into master. I'll update the PR base.

@dagar dagar changed the base branch from stable to master October 24, 2018 14:27
@dagar dagar changed the base branch from master to stable October 24, 2018 14:27
@dagar
Copy link
Member

dagar commented Oct 24, 2018

This doesn't apply cleanly to master. @hdiethelm could you rebase your commit to master and either change the pull request or open a new one?

@dagar dagar self-requested a review October 24, 2018 14:28
Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs to go into master, not stable.

@hdiethelm hdiethelm changed the base branch from stable to master October 24, 2018 16:40
@hdiethelm hdiethelm changed the base branch from master to stable October 24, 2018 16:42
@hdiethelm
Copy link
Author

Just did a pull request for the master branch and squashed the tree commits in one. Someone knows how to change both "into" and "from" for a pull request?

@hdiethelm hdiethelm closed this Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants