Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]: posix shutdown investigation/hacks #11525

Closed
wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Feb 22, 2019

  • review posix shutdown
  • review px4 client/server locking (and cleanup)

What's the relation to unit tests failing with the new px4 work queue? #11261

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's all good.

And the unit tests don't stall anymore for me locally.

@julianoes
Copy link
Contributor

I don't understand the dyn test failure:

      Start 31: dyn
31/34 Test #31: dyn ..............................***Failed  Required regular expression not found.Regex=[1: PASSED
]  0.02 sec
ERROR [dyn] ./examples__dyn_hello.px4mod: cannot open shared object file: No such file or directory
INFO  [px4] Creating symlink /home/julianoes/src/Firmware/ROMFS/px4fmu_test -> /home/julianoes/src/Firmware/build/px4_sitl_test/tmp/etc

______  __   __    ___ 
| ___ \ \ \ / /   /   |
| |_/ /  \ V /   / /| |
|  __/   /   \  / /_| |
| |     / /^\ \ \___  |
\_|     \/   \/     |_/

px4 starting.

57 WARNING: setRealtimeSched failed (not run as root?)
INFO  [px4] Calling startup script: /bin/sh /home/julianoes/src/Firmware/posix-configs/SITL/init/test/test_dyn_hello 0
Shutting down

@dagar
Copy link
Member Author

dagar commented Feb 25, 2019

I don't understand the dyn test failure:

      Start 31: dyn
31/34 Test #31: dyn ..............................***Failed  Required regular expression not found.Regex=[1: PASSED
]  0.02 sec
ERROR [dyn] ./examples__dyn_hello.px4mod: cannot open shared object file: No such file or directory
INFO  [px4] Creating symlink /home/julianoes/src/Firmware/ROMFS/px4fmu_test -> /home/julianoes/src/Firmware/build/px4_sitl_test/tmp/etc

______  __   __    ___ 
| ___ \ \ \ / /   /   |
| |_/ /  \ V /   / /| |
|  __/   /   \  / /_| |
| |     / /^\ \ \___  |
\_|     \/   \/     |_/

px4 starting.

57 WARNING: setRealtimeSched failed (not run as root?)
INFO  [px4] Calling startup script: /bin/sh /home/julianoes/src/Firmware/posix-configs/SITL/init/test/test_dyn_hello 0
Shutting down

The path seems to be wrong now.

@dagar dagar mentioned this pull request Feb 26, 2019
px4_daemon::Pxh::stop();
_exit_requested = true;

px4_systemreset(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar , did you want this to be px4_system_reset?

@MaEtUgR
Copy link
Member

MaEtUgR commented Mar 2, 2019

I did a quick test because I though it might fix #11027 but doesn't but it looks like a start.

@dagar
Copy link
Member Author

dagar commented Mar 2, 2019

I did a quick test because I though it might fix #11027 but doesn't but it looks like a start.

It's intended as a start. There's a lot more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants