Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander: improve message for RC override event #13142

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Oct 9, 2019

Describe problem solved by the proposed pull request
@cmic0 just discussed with me over lunch that "Autopilot off" is a really bad thing to hear when flying an aircraft since that means the controller you need for normal flight is gone and it's an emergency. Also for a multicopter you could interpret it as the autopilot hardware turning off which is totally undesired in flight.

Describe your preferred solution
I suggest (it was @cmic0 's idea) to just say "Autonomy off" because it's far less mistakable.

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better!

@cmic0
Copy link
Contributor

cmic0 commented Oct 9, 2019

Thanks for taking care @MaEtUgR!
Yes, having the autopilot off means that you don't even have primary flight modes running on the autopilot (for example rate stabilization) and you are purely flying in manual: this could be very risky if the aircraft is not intrinsically stable. Totally agree that on a multicopter this is highly undesired :)!
"Autonomy off" seems to be more clear.

@MaEtUgR MaEtUgR merged commit ca711fe into master Oct 9, 2019
@MaEtUgR MaEtUgR deleted the rc-override-message branch October 9, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants