Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: choose logged instances by logger_topics file #14066

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

NicolasM0
Copy link
Contributor

New logger versions do not allow to log multiple instances of a topic when using 'logger_topics.txt'

This commit restores the previous behavior (log all instances of a topic) and add an option to specify an instance to log

Tested with default (all instances) and a specific instance

new versions of logger does not allow to log multiple instances of a topic when using 'logger_topics.txt'

This commit restores the default behavior (log all instances of a topic) and ad the option to specify an instance to log
@dagar dagar requested a review from bkueng January 30, 2020 14:31
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamishwillee
Copy link
Contributor

hamishwillee commented Feb 2, 2020

@NicolasM0 Can you confirm you are taking docs update on? #14066 (review)

@NicolasM0
Copy link
Contributor Author

@hamishwillee I confirm

@hamishwillee
Copy link
Contributor

Thanks! Let me know if you need any docs support.

NicolasM0 added a commit to NicolasM0/Devguide that referenced this pull request Feb 3, 2020
Add description on how to use the new option to log a specific instance using loger_topics.txt file (added in this commit: PX4/PX4-Autopilot#14066 (comment))
bkueng pushed a commit to PX4/PX4-Devguide that referenced this pull request Feb 4, 2020
Add description on how to use the new option to log a specific instance using loger_topics.txt file (added in this commit: PX4/PX4-Autopilot#14066 (comment))
@NicolasM0 NicolasM0 deleted the fix_logger branch April 28, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants