logger: choose logged instances by logger_topics file #14066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new versions of logger does not allow to log multiple instances of a topic when using 'logger_topics.txt' This commit restores the default behavior (log all instances of a topic) and ad the option to specify an instance to log
bkueng
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Can you also update the docs? -> https://dev.px4.io/master/en/log/logging.html#configuration
|
@NicolasM0 Can you confirm you are taking docs update on? #14066 (review) |
|
@hamishwillee I confirm |
|
Thanks! Let me know if you need any docs support. |
NicolasM0
added a commit
to NicolasM0/Devguide
that referenced
this pull request
Feb 3, 2020
Add description on how to use the new option to log a specific instance using loger_topics.txt file (added in this commit: PX4/PX4-Autopilot#14066 (comment))
bkueng
pushed a commit
to PX4/PX4-Devguide
that referenced
this pull request
Feb 4, 2020
Add description on how to use the new option to log a specific instance using loger_topics.txt file (added in this commit: PX4/PX4-Autopilot#14066 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New logger versions do not allow to log multiple instances of a topic when using 'logger_topics.txt'
This commit restores the previous behavior (log all instances of a topic) and add an option to specify an instance to log
Tested with default (all instances) and a specific instance