jMAVSim: warn if not Java 8 is used, select Java 8 in setup script #14067

julianoes · 2020-01-30T13:51:31Z

This adds a check before running jMAVSim if Java 8 is selected.

It also selects Java 8 by default in the Ubuntu setup script.

This allows us to print an error message instead of a weird Java failure further down the road. Better yet would be if this would take down everything, so a user does not have to scroll up to read the message.

codecov · 2020-01-30T14:03:35Z

Codecov Report

Merging #14067 into master will decrease coverage by 1.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14067      +/-   ##
==========================================
- Coverage   54.54%   52.63%   -1.92%     
==========================================
  Files         605      605              
  Lines       51370    51388      +18     
==========================================
- Hits        28021    27047     -974     
- Misses      23349    24341     +992

Flag	Coverage Δ
#mavsdk	`?`
#python	`3.22% <ø> (+0.06%)`	⬆️
#sitl_mission_FW	`29.4% <ø> (-0.01%)`	⬇️
#sitl_mission_MC_box	`29.75% <ø> (ø)`	⬆️
#sitl_mission_MC_offboard_att	`28.21% <ø> (-0.06%)`	⬇️
#sitl_mission_MC_offboard_pos	`28.52% <ø> (ø)`	⬆️
#sitl_mission_Rover	`26.25% <ø> (+0.03%)`	⬆️
#sitl_mission_VTOL_standard	`100% <ø> (+66.08%)`	⬆️
#sitl_mission_VTOL_tailsitter	`33.93% <ø> (-0.03%)`	⬇️
#sitl_python_FW	`29.55% <ø> (+0.07%)`	⬆️
#sitl_python_MC_box	`100% <ø> (+70.17%)`	⬆️
#sitl_python_MC_offboard_att	`28.36% <ø> (+0.02%)`	⬆️
#sitl_python_MC_offboard_pos	`28.67% <ø> (+0.07%)`	⬆️
#sitl_python_Rover	`?`
#sitl_python_VTOL_standard	`?`
#sitl_python_VTOL_tailsitter	`34.07% <ø> (+0.04%)`	⬆️
#unittest	`34.89% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
...b/flight_tasks/tasks/Descend/FlightTaskDescend.cpp	`0% <0%> (-83.34%)`	⬇️
src/modules/navigator/takeoff.cpp	`3.92% <0%> (-76.48%)`	⬇️
...flight_tasks/tasks/Failsafe/FlightTaskFailsafe.cpp	`0% <0%> (-73.92%)`	⬇️
src/modules/vtol_att_control/standard.cpp	`7.27% <0%> (-70%)`	⬇️
src/modules/navigator/rtl.cpp	`14.46% <0%> (-44.22%)`	⬇️
...lib/flight_tasks/tasks/Manual/FlightTaskManual.cpp	`0% <0%> (-38.89%)`	⬇️
src/modules/navigator/loiter.cpp	`8.16% <0%> (-38.78%)`	⬇️
src/modules/simulator/simulator_mavlink.cpp	`58.67% <0%> (-19.71%)`	⬇️
src/modules/mavlink/mavlink_timesync.cpp	`72.5% <0%> (-15%)`	⬇️
..._tasks/tasks/Utility/ManualVelocitySmoothingXY.hpp	`78.57% <0%> (-14.29%)`	⬇️
... and 35 more

hamishwillee

Yes, this works (and makes sense "by inspection"). Thanks!

julianoes added 2 commits January 30, 2020 14:48

Tools: check for Java 8 on Linux

a74287f

This allows us to print an error message instead of a weird Java failure further down the road. Better yet would be if this would take down everything, so a user does not have to scroll up to read the message.

setup: select Java 8 after installation

278e4b9

julianoes requested a review from hamishwillee January 30, 2020 13:51

hamishwillee approved these changes Jan 31, 2020

View reviewed changes

dagar merged commit a8c3944 into master Jan 31, 2020

dagar deleted the pr-jmavsim-java8 branch January 31, 2020 03:45

weekly-digest bot mentioned this pull request Feb 2, 2020

Weekly Digest (26 January, 2020 - 2 February, 2020) #14084

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jMAVSim: warn if not Java 8 is used, select Java 8 in setup script #14067

jMAVSim: warn if not Java 8 is used, select Java 8 in setup script #14067

julianoes commented Jan 30, 2020

codecov bot commented Jan 30, 2020 •

edited

Loading

hamishwillee left a comment

jMAVSim: warn if not Java 8 is used, select Java 8 in setup script #14067

jMAVSim: warn if not Java 8 is used, select Java 8 in setup script #14067

Conversation

julianoes commented Jan 30, 2020

codecov bot commented Jan 30, 2020 • edited Loading

Codecov Report

hamishwillee left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 30, 2020 •

edited

Loading