Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete NAVIGATION_STATE_AUTO_RTGS (OBC datalink loss) #14307

Merged
merged 11 commits into from
Mar 12, 2020
Merged

delete NAVIGATION_STATE_AUTO_RTGS (OBC datalink loss) #14307

merged 11 commits into from
Mar 12, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 5, 2020 •
edited
Loading

TODO:

  • logic to transition NAV_DLL_ACT and NAV_RCL_ACT?
  • carefully review state machine

@dagar
Copy link
Member Author

dagar commented Mar 5, 2020

@julianoes @bkueng @thomasgubler any objection to this (high level)? I still need to review some of the details carefully.

@dagar dagar added this to the Release v1.11.0 milestone Mar 5, 2020
@LorenzMeier
Copy link
Member

No, this is great. We need to be having less code, but the code we have needs to be maintained well. I'm pretty sure that the "mainline failsafe code" can be made OBC compliant with a few tweaks if needed.

@hamishwillee
Copy link
Contributor

Note to self, this has a few associated docs changes in https://docs.px4.io/master/en/config/safety.html#rc_loss_failsafe . This will need to be done before v1.11 branch gets taken.

@bkueng
Copy link
Member

bkueng commented Mar 6, 2020

@julianoes @bkueng @thomasgubler any objection to this (high level)?

no

julianoes
julianoes reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! Do you understand what happens if someone still has this param set though?

@LorenzMeier
Copy link
Member

If a user had it configured to that they will then get the same as having it disabled. Given that it states that it was for a competition and that competition is still months (or years) away, it is fine to remove this.

@LorenzMeier
Update px4_custom_mode.h
24e6c18 
Remove PX4_CUSTOM_SUB_MODE_AUTO_RTGS but retain the enum ordering / values as this is exposed externally (QGC).
@LorenzMeier
Copy link
Member

@dagar Could you provide a test plan for @PX4/testflights ? That seems to be the last step to wrap this up.

LorenzMeier
LorenzMeier previously approved these changes Mar 8, 2020
View reviewed changes
@dagar
Copy link
Member Author

dagar commented Mar 9, 2020

That's awesome! Do you understand what happens if someone still has this param set though?

I'll add some logic in commander to manually migrate plus a mavlink message. We can drop it after a release or so.

julianoes
julianoes previously approved these changes Mar 10, 2020
View reviewed changes
@dagar dagar dismissed stale reviews from julianoes and LorenzMeier via 00da8f3 March 10, 2020 14:05
@dagar
Copy link
Member Author

dagar commented Mar 10, 2020

Added commander logic to migrate NAV_DLL_ACT and NAV_RCL_ACT to regular RTL mode if set to the CASA Outback Challenge rules.

@dagar dagar requested a review from a team March 10, 2020 17:38
julianoes
julianoes previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that seems safe now!

@dannyfpv
Copy link

dannyfpv commented Mar 11, 2020 •
edited by Tony3dr
Loading

Due to the weather, we did some Indoor Flights
Pixhawk 4 v5 f-450
Modes Tested
indoor test
Stabilized Mode: Good.

- Procedure
Arm and Takeoff in Stabilized Mode,

Notes:
No issues noted good flight in general.

Log:
https://review.px4.io/plot_app?log=c93e134e-dd86-4ddd-9951-df03de4e64de

Pixhawk 4 mini v5 f-450
Modes Tested
indoor test
Stabilized Mode: Good.

- Procedure
Arm and Takeoff in Stabilized Mode,

Notes:
No issues noted good flight in general.

Log:
https://review.px4.io/plot_app?log=dd959780-62da-4fee-bbc2-5db29cebbc25

@jorge789
Copy link

Tested on PixRacer V4

Indoor Flight Test
Modes Tested
Stabilized Mode: Good.

Procedure
Arm and Take off in stabilized mode.

Notes
No issues noted, good flight in general.

Log https://review.px4.io/plot_app?log=7509c294-12e1-4107-8597-80572372fc31

Tested on CUAV nano V5

Indoor Flight Test
Modes Tested
Stabilized Mode: Good.

Procedure
Arm and Take off in stabilized mode.

Notes
No issues noted, good flight in general.

Log https://review.px4.io/plot_app?log=160409ba-174e-4578-8d38-ad8569d46ec0

@dagar dagar merged commit 5d33b9e into master Mar 12, 2020
@dagar dagar deleted the pr-nav_state_cleanup branch March 12, 2020 02:45
@mrpollo mrpollo mentioned this pull request Mar 16, 2020
Closed
@MaEtUgR MaEtUgR mentioned this pull request Feb 4, 2021
Closed
MaEtUgR added a commit that referenced this pull request Nov 16, 2022
@MaEtUgR
navigator_params: remove deprecated parameters
ddca300 
The usage of `NAV_AH_...` was removed in
5d33b9e
#14307
dagar pushed a commit that referenced this pull request Nov 16, 2022
@MaEtUgR @dagar
navigator_params: remove deprecated parameters
d4f18bd 
The usage of `NAV_AH_...` was removed in
5d33b9e
#14307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier left review comments

@julianoes julianoes julianoes left review comments

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹
Projects
None yet
Milestone
Release v1.11.0
Development

Successfully merging this pull request may close these issues.
8 participants
@dagar @LorenzMeier @hamishwillee @bkueng @dannyfpv @jorge789 @julianoes @bresch