-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdev: posix remove std::map usage #15368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should do a quick check of the devmap and filemap usage in a few cases. pxh> list_files
INFO [cdev] Files:
/obj/log_message0
/obj/parameter_update0
/obj/sensor_accel0
/obj/sensor_gyro0
/dev/mag0
/obj/sensor_mag0
/dev/baro0
/obj/sensor_baro0
/obj/actuator_outputs0
/obj/vehicle_angular_velocity_groundtruth0
/obj/vehicle_attitude_groundtruth0
/obj/vehicle_global_position_groundtruth0
/obj/vehicle_local_position_groundtruth0
/obj/battery_status0
/dev/tone_alarm0
/obj/input_rc0
/obj/sensor_selection0
/obj/vehicle_imu0
/obj/led_control0
/dev/led0
/obj/tune_control0
/obj/power_button_state0
/obj/vehicle_command_ack0
/obj/vehicle_command0
/obj/vehicle_control_mode0
/obj/vehicle_status0
/obj/actuator_armed0
/obj/commander_state0
/obj/vehicle_status_flags0
/obj/vehicle_acceleration0
/obj/vehicle_angular_acceleration0
/obj/vehicle_angular_velocity0
/obj/vehicle_imu_status0
/obj/vehicle_local_position0
/obj/position_setpoint_triplet0
/obj/sensor_combined0
/obj/sensor_preflight0
/obj/test_motor0
/dev/pwm_output0
/obj/actuator_controls_00
/obj/actuator_controls_30
/obj/ekf2_timestamps0
/obj/landing_gear0
/obj/rate_ctrl_status0
/obj/multirotor_motor_limits0
/obj/vehicle_attitude0
/obj/vehicle_local_position_setpoint0
/obj/vehicle_land_detected0
/obj/vehicle_gps_position0
/obj/mavlink_log0
/obj/vehicle_magnetometer0
/obj/telemetry_status0
/obj/logger_status0
/obj/vehicle_air_data0
/obj/vehicle_odometry0
/obj/estimator_sensor_bias0
/obj/estimator_status0
/obj/ekf_gps_drift0
/obj/estimator_innovations0
/obj/estimator_innovation_variances0
/obj/estimator_innovation_test_ratios0
/obj/vehicle_attitude_setpoint0
/obj/vehicle_rates_setpoint0
/obj/home_position0 |
2b0ec5e
to
c0c509d
Compare
43d46ec
to
090b3f5
Compare
bkueng
previously approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
(although I doubt that that's the only or main complication on QuRT)
Co-authored-by: Beat Küng <beat-kueng@gmx.net>
Yes this is only a start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make things a little easier for platforms like QuRT (voxl snapdragon) where there are libstdc++ complications. The original SITL performance issues (#7834) this resolved aren't as relevant anymore now that the vast majority of uORB usage in the system isn't dependent on file descriptors.
You could think of this as more or less reverting #7834, but with some simplification.