Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdev: posix remove std::map usage #15368

Merged
merged 3 commits into from
Jul 21, 2020
Merged

cdev: posix remove std::map usage #15368

merged 3 commits into from
Jul 21, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Jul 17, 2020

This is to make things a little easier for platforms like QuRT (voxl snapdragon) where there are libstdc++ complications. The original SITL performance issues (#7834) this resolved aren't as relevant anymore now that the vast majority of uORB usage in the system isn't dependent on file descriptors.

You could think of this as more or less reverting #7834, but with some simplification.

@dagar dagar requested a review from dakejahl July 17, 2020 23:17
@dagar
Copy link
Member Author

dagar commented Jul 17, 2020

We should do a quick check of the devmap and filemap usage in a few cases.

pxh> list_files
INFO  [cdev] Files:
   /obj/log_message0
   /obj/parameter_update0
   /obj/sensor_accel0
   /obj/sensor_gyro0
   /dev/mag0
   /obj/sensor_mag0
   /dev/baro0
   /obj/sensor_baro0
   /obj/actuator_outputs0
   /obj/vehicle_angular_velocity_groundtruth0
   /obj/vehicle_attitude_groundtruth0
   /obj/vehicle_global_position_groundtruth0
   /obj/vehicle_local_position_groundtruth0
   /obj/battery_status0
   /dev/tone_alarm0
   /obj/input_rc0
   /obj/sensor_selection0
   /obj/vehicle_imu0
   /obj/led_control0
   /dev/led0
   /obj/tune_control0
   /obj/power_button_state0
   /obj/vehicle_command_ack0
   /obj/vehicle_command0
   /obj/vehicle_control_mode0
   /obj/vehicle_status0
   /obj/actuator_armed0
   /obj/commander_state0
   /obj/vehicle_status_flags0
   /obj/vehicle_acceleration0
   /obj/vehicle_angular_acceleration0
   /obj/vehicle_angular_velocity0
   /obj/vehicle_imu_status0
   /obj/vehicle_local_position0
   /obj/position_setpoint_triplet0
   /obj/sensor_combined0
   /obj/sensor_preflight0
   /obj/test_motor0
   /dev/pwm_output0
   /obj/actuator_controls_00
   /obj/actuator_controls_30
   /obj/ekf2_timestamps0
   /obj/landing_gear0
   /obj/rate_ctrl_status0
   /obj/multirotor_motor_limits0
   /obj/vehicle_attitude0
   /obj/vehicle_local_position_setpoint0
   /obj/vehicle_land_detected0
   /obj/vehicle_gps_position0
   /obj/mavlink_log0
   /obj/vehicle_magnetometer0
   /obj/telemetry_status0
   /obj/logger_status0
   /obj/vehicle_air_data0
   /obj/vehicle_odometry0
   /obj/estimator_sensor_bias0
   /obj/estimator_status0
   /obj/ekf_gps_drift0
   /obj/estimator_innovations0
   /obj/estimator_innovation_variances0
   /obj/estimator_innovation_test_ratios0
   /obj/vehicle_attitude_setpoint0
   /obj/vehicle_rates_setpoint0
   /obj/home_position0

@dagar dagar force-pushed the pr-posix_std_remove branch from 2b0ec5e to c0c509d Compare July 17, 2020 23:25
bkueng
bkueng previously approved these changes Jul 21, 2020
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
(although I doubt that that's the only or main complication on QuRT)

Co-authored-by: Beat Küng <beat-kueng@gmx.net>
@dagar
Copy link
Member Author

dagar commented Jul 21, 2020

(although I doubt that that's the only or main complication on QuRT)

Yes this is only a start.

@dagar dagar merged commit b8b19f6 into master Jul 21, 2020
@dagar dagar deleted the pr-posix_std_remove branch July 21, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants