Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixer_module/tap_esc: fix usage of constrain() on input #15379

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jul 20, 2020

Describe problem solved by this pull request
I changed the input constraint in #15349 but screwed up the usage because I was convinced it's püass by reference. I'll double check for sure next time.

Describe your solution
It's pass by value and the return value has to be assigned again like @bkueng pointed out in https://github.com/PX4/Firmware/pull/15349/files#r457096522 Thanks!!

I changed the input constraint in #15349 but screwed up the usage
because I was convinced it's püass by reference. I'll double check
for sure next time.
@bkueng
Copy link
Member

bkueng commented Jul 20, 2020

@julianoes have you seen this?

 [mavsdk_tests] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[mavsdk_tests] mavsdk_tests is a Catch v2.9.2 host application.
[mavsdk_tests] Run with -? for options
[mavsdk_tests] -------------------------------------------------------------------------------
[mavsdk_tests] Fly square Multicopter Missions
[mavsdk_tests] -------------------------------------------------------------------------------
[mavsdk_tests] ../../../test/mavsdk_tests/test_multicopter_mission.cpp:55
[mavsdk_tests] ...............................................................................
[mavsdk_tests] ../../../test/mavsdk_tests/test_multicopter_mission.cpp:70: FAILED:
[mavsdk_tests]   {Unknown expression after the reported line}
[mavsdk_tests] due to a fatal error condition:
[mavsdk_tests]   SIGSEGV - Segmentation violation signal
[mavsdk_tests] ===============================================================================

@bkueng bkueng merged commit 987826f into master Jul 20, 2020
@bkueng bkueng deleted the input-limit-fix branch July 20, 2020 07:23
@dagar
Copy link
Member

dagar commented Jul 20, 2020

If anyone has this hardware on hand we should do a quick pass updating tap_esc to use OutputModuleInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants