-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc.sensors: try starting iis2mdc #24254
Conversation
I recently discovered that the lis2mdl and iis2mdc are identical from a software perspective. Do we want to keep both drivers around @dagar? This means running the iis2mdc driver will detect an lis2mdl as an iis2mdc |
If they're actually identical we can't really be probing both here. Literally identical 100% or any actual differences? |
Sounds like identical from a firmware perspective. But I think the actual manufacturing of the MEMs is different. |
eeee410
to
43c85db
Compare
It looks like the lis2mdl isn't included in common magnetometers. I've updated rc.sensors to try starting the iis2mdc first, then trying the lis2mdl if it fails. |
I think ideally we'd have only one driver, but I wrote the iis2mdc because I didn't even realize they were the same part. So maybe ideally one driver with a nice comment at the top referencing the support for those multiple devices. And then we delete the duplicate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this for now and I can come back around to deleting the lis2mdl completely
The new ARK SAM GPS uses the iis2mdc over I2C directly.