Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SensorGps.msg to improve naming #24399

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dakejahl
Copy link
Contributor

Replaces #24352

  • Rename fields to remove units and improve naming
  • Cleaned up comments

Please see the questions in the TODOs

@PetervdPerk-NXP
Copy link
Member

Good chance to rename to GNSS as well?

@dakejahl
Copy link
Contributor Author

Good chance to rename to GNSS as well?

Probably should..

@hamishwillee
Copy link
Contributor

@dakejahl
Copy link
Contributor Author

Does this align with https://mavlink.io/en/messages/development.html#GNSS_INTEGRITY ?

Right now we're not collecting most of that information

@hamishwillee
Copy link
Contributor

Right now we're not collecting most of that information

OK. Just putting it there for your consideration.

@dakejahl
Copy link
Contributor Author

dakejahl commented Mar 4, 2025

Good chance to rename to GNSS as well?

Probably should..

487 matches across 136 files

oof

@dakejahl dakejahl marked this pull request as draft March 4, 2025 09:50
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants