gz: use server config file for loading world plugins #24441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamishwillee let's chat sometime about adding docs for gz plugins |
dagar
reviewed
Mar 4, 2025
dagar
reviewed
Mar 4, 2025
|
I added magnetometer callback to GZBridge. Tested functional. |
dakejahl
commented
Mar 4, 2025
mbjd
added a commit
to PX4/PX4-gazebo-models
that referenced
this pull request
Mar 4, 2025
just for developing the plugin. will change to new plugin infrastructure once PX4/PX4-Autopilot#24441 merges.
mbjd
added a commit
that referenced
this pull request
Mar 4, 2025
atm it does nothing, but it builds and runs. - temporarily loaded by specifying in world sdf file. Tools/simulation/gz submodule update does that. Waiting for #24441 - Build works but is very ugly. TODOs: - separate completely from OpticalFlowSystem - Add dependency on MovingPlatformController in a way that it works when setting the world with env var, not only when setting it with build target gz_$MODELNAME_$WORLDNAME (just always?)
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
mbjd
added a commit
that referenced
this pull request
Mar 5, 2025
atm it does nothing, but it builds and runs. - temporarily loaded by specifying in world sdf file. Tools/simulation/gz submodule update does that. Waiting for #24441 - Build works but is very ugly. TODOs: - separate completely from OpticalFlowSystem - Add dependency on MovingPlatformController in a way that it works when setting the world with env var, not only when setting it with build target gz_$MODELNAME_$WORLDNAME (just always?)
AlexKlimaj
approved these changes
Mar 6, 2025
mbjd
added a commit
to PX4/PX4-gazebo-models
that referenced
this pull request
Mar 7, 2025
mbjd
added a commit
to PX4/PX4-gazebo-models
that referenced
this pull request
Mar 7, 2025
just for developing the plugin. will change to new plugin infrastructure once PX4/PX4-Autopilot#24441 merges.
mbjd
added a commit
to PX4/PX4-gazebo-models
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo docs
https://gazebosim.org/api/sim/8/server_config.html
TLDR; the plugins can be loaded via a config file. This ensures we have all the plugins needed for PX4 without hardcoding them into the world files.