Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[continue:] Moving towards multi-sensor-per-same-measurement fusion #668

Merged
merged 11 commits into from
Dec 5, 2019

Conversation

kamilritz
Copy link
Contributor

This PR is exactly the same as: #652,
but added as a separate branch to ECL. Such that we can test the PR's compatibility with the Firmware's CI.

@kamilritz kamilritz force-pushed the pr-refactor-velpos branch 2 times, most recently from f944135 to 63213ed Compare November 11, 2019 11:56
priseborough
priseborough previously approved these changes Nov 12, 2019
Copy link
Collaborator

@priseborough priseborough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please delay merging until corresponding upstream PX4/Firmware changes PX4/PX4-Autopilot#13127 are approved and ready to merge so that merging can be coordinated.

@mhkabir
Copy link
Member

mhkabir commented Nov 13, 2019

Question: why do we even use the std. deviation in the estimator interface?

  1. PX4 side uses variances (from cov matx)
  2. Fusion uses variances

So we just end up uselessly square rooting and then squaring.


return true;
}else{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}else{
} else {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is only the tip of the iceberg. At some point we really need a formatter.

@kamilritz
Copy link
Contributor Author

@mhkabir I also noticed that and want get rid of the std deviation. I am in the process of cleaning this and some other things up. But these changes are based on top of this refactor. I am eager to get them in after this PR.

@mhkabir
Copy link
Member

mhkabir commented Nov 21, 2019

@kamilritz What is missing here? Let's bring this in soon.

@kamilritz
Copy link
Contributor Author

@mhkabir Glad you feel the same. Waiting on the firmware PR to be ready.

@priseborough priseborough merged commit 1813034 into master Dec 5, 2019
@kamilritz kamilritz deleted the pr-refactor-velpos branch December 9, 2019 13:29
@xdwgood
Copy link

xdwgood commented Sep 9, 2020

@kamilritz https://github.com/PX4/ecl/blob/master/EKF/vel_pos_fusion.cpp#L168

This is just KP, why does the code say it is KHP, where does H come from? thank you very much 😃

Is it because the H matrix is 1?

@kamilritz
Copy link
Contributor Author

Is it because the H matrix is 1?

Yes. To be a bit more precise. It is a vector of size 1x24 full of zeros with a single 1 at the location of the measurement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants