-
Notifications
You must be signed in to change notification settings - Fork 511
[continue:] Moving towards multi-sensor-per-same-measurement fusion #668
Conversation
f944135
to
63213ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please delay merging until corresponding upstream PX4/Firmware changes PX4/PX4-Autopilot#13127 are approved and ready to merge so that merging can be coordinated.
Question: why do we even use the std. deviation in the estimator interface?
So we just end up uselessly square rooting and then squaring. |
|
||
return true; | ||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}else{ | |
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is only the tip of the iceberg. At some point we really need a formatter.
@mhkabir I also noticed that and want get rid of the std deviation. I am in the process of cleaning this and some other things up. But these changes are based on top of this refactor. I am eager to get them in after this PR. |
@kamilritz What is missing here? Let's bring this in soon. |
@mhkabir Glad you feel the same. Waiting on the firmware PR to be ready. |
63c0e1a
to
c8043bf
Compare
(cherry picked from commit 0faea89da2a3326d070a6ecca93ec52ec3e29591)
97f634a
to
ea7173a
Compare
ea7173a
to
fd1ecb7
Compare
@kamilritz https://github.com/PX4/ecl/blob/master/EKF/vel_pos_fusion.cpp#L168 This is just Is it because the H matrix is 1? |
Yes. To be a bit more precise. It is a vector of size 1x24 full of zeros with a single 1 at the location of the measurement. |
This PR is exactly the same as: #652,
but added as a separate branch to ECL. Such that we can test the PR's compatibility with the Firmware's CI.