Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step lr_scheduler on epoch end in hapi/model.py fit #27730

Merged
merged 9 commits into from
Oct 15, 2020

Conversation

heavengate
Copy link
Contributor

@heavengate heavengate commented Sep 29, 2020

PR types

Function optimization

PR changes

Others

Describe

LRScheduler in paddle.optimizer.lr_scheduler decay learning rate by epoch and LRScheduler.step() should be called on each epoch end, add LRScheduler.step() in fit in hapi/model.py

Tested on static/dygraph TSM/YOLOv3 ok

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@heavengate heavengate requested review from saxon-zh, qingqing01 and LielinJiang and removed request for saxon-zh September 29, 2020 14:04
saxon-zh
saxon-zh previously approved these changes Sep 29, 2020
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LielinJiang
LielinJiang previously approved these changes Oct 10, 2020
@heavengate heavengate closed this Oct 13, 2020
@heavengate heavengate reopened this Oct 13, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 13, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 13, 2020
@heavengate heavengate merged commit b808979 into PaddlePaddle:develop Oct 15, 2020
@heavengate heavengate deleted the step_lr_on_epoch_end branch October 15, 2020 03:14
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
* step lr_scheduler on epoch end in hapi/model.py fit. test=develop
MingMingShangTian pushed a commit to MingMingShangTian/Paddle that referenced this pull request Oct 15, 2020
* step lr_scheduler on epoch end in hapi/model.py fit. test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants