fix test directory migration #27885
Merged
fix test directory migration #27885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
approved these changes
Oct 14, 2020
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
* fix test directory migration * change assert to self.assertXXX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Unittest file
test_directory_migration.pyis used to test the correction of module path in PR #25898 .To test the new path of modules, it will write all the new modules into a file and then run it.
Because all the modules are tested at the same time, it can't find which module occurs error.
This PR is used to position the specific module that occurs error.
The following list is the modules that needs to be checked, they will be writed into a file and be checked in order.
For example, if module
paddle.to_tensoris deleted.Before this PR, the error message is
It gives the wrong error message that
Can't import Module paddle.static.nn.embedding.Because all the modules are tested at the same time. No matter which module occurs error, only the last module
paddle.static.nn.embeddingwill be reported as a problem.After we position the specific module in this PR, the error message is
It can clearly tell users that
cannot import name 'to_tensor'.