Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 4 files, from clear include by iwyu #27895

Merged
merged 1 commit into from
Oct 14, 2020
Merged

revert 4 files, from clear include by iwyu #27895

merged 1 commit into from
Oct 14, 2020

Conversation

wanghuancoder
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

PR27267:#27267
清理了大量include,已加速编译速度。使用了iwyu。
而iwyu是根据编译选项进行优化的。在优化中没有打开WITH_PSLIB开关。
导致PSLIB相关的、不该删除的include被删除,导致编译失败。
本PR回滚4个文件。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wanghuancoder wanghuancoder merged commit 41aad9b into PaddlePaddle:develop Oct 14, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants