Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the examples which use paddle.static.nn.fc. #27904

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

Xreki
Copy link
Contributor

@Xreki Xreki commented Oct 13, 2020

PR types

Others

PR changes

Docs

Describe

#27768 修改了paddle.static.nn.fc接口的部分参数名,但是一些代码示例没有随之改过来。这个PR修复所有引用到paddle.static.nn.fc的代码示例。
image

其中红色框标注的是源码实现中,调用的是fluid.layers.nn.fc,具体见https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid/layers/rnn.py#L3397 ,因此不用修改。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 13, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@Xreki
Copy link
Contributor Author

Xreki commented Oct 14, 2020

2020-10-13 20:27:58 ****************
2020-10-13 20:27:58 0. You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for python/paddle/fluid/compiler.py, which manages the underlying code for fluid.
2020-10-13 20:27:58 1. You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for python/paddle/fluid/framework.py, which manages the underlying code for fluid.
2020-10-13 20:27:58 2. You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for python/paddle/fluid/backward.py, which manages the underlying code for fluid.
2020-10-13 20:27:58 There are 3 approved errors.
2020-10-13 20:27:58 ****************

@luotao1 帮忙review下。

2020-10-13 21:43:20 ****************
2020-10-13 21:43:20 0. You must have one TPM (saxon-zh or jzhang533 or swtkiwi or Heeenrrry or TCChenlong) approval for the api change for the management reason of API document.
2020-10-13 21:43:20 1. APIs without core.ops: 
2020-10-13 21:43:20 paddle.fluid.layers.py_func
2020-10-13 21:43:20 paddle.fluid.backward.append_backward
2020-10-13 21:43:20 paddle.static.append_backward
2020-10-13 21:43:20 paddle.static.py_func
2020-10-13 21:43:20 You must have one RD (zhiqiu (Recommend) or phlrain) approval for the api change for the opreator-related api without 'core.ops'.
2020-10-13 21:43:20 For more details, please click [https://github.com/PaddlePaddle/Paddle/wiki/paddle_api_development_manual.md]
2020-10-13 21:43:20 
2020-10-13 21:43:20 There are 2 approved errors.
2020-10-13 21:43:20 ****************

@TCChenlong@zhiqiu 帮忙review下。

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for framework.py

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki merged commit b301adc into PaddlePaddle:develop Oct 14, 2020
@Xreki Xreki deleted the api2.0/fix_examples_fc branch October 14, 2020 02:17
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants