-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneDNN BatchNorm + Act fusion pass. #27912
oneDNN BatchNorm + Act fusion pass. #27912
Conversation
Thanks for your contribution! |
This reverts commit 7c89ba0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luotao1 Could you please help. I see following error occur, although it is not related to my changes: Moreover in PR-CI-Coverage and PR-CI-Windows i get Finally in PR-CI-Approval I see complaint about the usage of |
|
@luotao1 All CI-checks (except approval) passed. Could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
Others
Describe
This PR adds oneDNN pass for BatchNorm + Act function fusion. Currently only ReLU is supported as activation function.
Performance improvement is around 2.8% - benchmarked on pvanet_ocr model using Xeon 6148 machine. Run with 40 threads.