Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with flags fp32 and int8 #27954

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Oct 14, 2020

PR types

Bug fixes

PR changes

APIs

Describe

This PR fixes problem with different uses of flags --enable_int8 , --enable_fp32 and --enable_bf16.
Bfloat16 test for image classification models uses the same functions as int8 and quant tests and the default value for --enable_int8 and --enable_fp32 is true that is why after adding --enable_bf16 there were some conflicts.
This PR changes the default value for enable_int8 and --enable_bf16 to false and adds setting these flags to every test in CMake files.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja added the Intel label Oct 14, 2020
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 840c521 into PaddlePaddle:develop Oct 15, 2020
MingMingShangTian pushed a commit to MingMingShangTian/Paddle that referenced this pull request Oct 15, 2020
@wozna wozna deleted the fix_flags branch February 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants