add musl docker build script #28027
Merged
add musl docker build script #28027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
luotao1
reviewed
Oct 16, 2020
paddle/scripts/musl_build/README.md
Outdated
| - Dockerfile: build docker defination file. | ||
|
|
||
| # maintainer | ||
| - Chen Zhiyu (quby@sina.com) |
luotao1
reviewed
Oct 16, 2020
| -DWITH_TESTING=OFF | ||
|
|
||
| echo "compile with make: $" | ||
| # shellcheck disable=2068 |
There was a problem hiding this comment.
后面$@会报错，这个是给后面加make 参数用的， 比如-j8
luotao1
reviewed
Oct 16, 2020
| pip install -r /paddle/python/requirements.txt | ||
|
|
||
| # configure project with cmake | ||
| cmake /paddle -DWITH_MUSL=ON DWITH_CRYPTO=OFF -DWITH_MKL=OFF -DWITH_GPU=OFF -DWITH_TESTING=OFF |
There was a problem hiding this comment.
MUSL不能和MKL共用么？
-DWITH_TESTING=OFF可以去掉，默认就是OFF
There was a problem hiding this comment.
MKL是预编译的so，目前的只有glibc的。intel提供了测试的mkl-musl，会在下个版本中尝试合入。
There was a problem hiding this comment.
-DWITH_TESTING=OFF 去掉了
| cmake /paddle -DWITH_MUSL=ON DWITH_CRYPTO=OFF -DWITH_MKL=OFF -DWITH_GPU=OFF -DWITH_TESTING=OFF | ||
|
|
||
| # run the make to build project | ||
| make |
There was a problem hiding this comment.
这部分是手动的，用户可以自行选择
There was a problem hiding this comment.
自动部分，在ci脚本上是支持加-j的
| OUTPUT_DIR=$(realpath $OUTPUT_DIR) | ||
| echo "build output: $OUTPUT_DIR" | ||
|
|
||
| # shellcheck disable=2086,2068 |
There was a problem hiding this comment.
shellcheck 会报${var[@]} 展开为多项，这个原意就是要动态增加参数，所以要跳过这个检查
chenwhql
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe