Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AVX512 instruction check for C-API #28087

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Add AVX512 instruction check for C-API #28087

merged 2 commits into from
Oct 20, 2020

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Oct 19, 2020

PR types

Bug fixes

PR changes

APIs

Describe

This PR adds avx512_core instructions check in C-API for bfloat16.
This should resolve the issue #28025.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jczaja
jczaja approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Oct 20, 2020

图片

Since our CI machine has avx512 core, @XieYunshen Could you help see this coverage line?

luotao1
luotao1 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit a21b571 into PaddlePaddle:develop Oct 20, 2020
@wozna wozna deleted the avx_check branch February 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@jczaja jczaja jczaja approved these changes

Assignees
No one assigned
Labels
BF16 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wozna @luotao1 @jczaja