Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vision datasets return PIL.Image as default #28264

Merged
merged 10 commits into from
Oct 30, 2020

Conversation

LielinJiang
Copy link
Contributor

PR types

New features

PR changes

APIs

Describe

Make vision datasets return PIL.Image as default

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LielinJiang LielinJiang requested review from qingqing01, heavengate and saxon-zh and removed request for qingqing01 and heavengate October 27, 2020 11:54
backend(str, optional): Specifies which type of image be returned:
PIL.Image or numpy.ndarray. Should be one of {'pil', 'cv2'}.
If this option is not set, will get backend from ``paddle.vsion.get_image_backend`` ,
default backend is 'pil'. Default: None.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个表述有点怪,是不是直接default值设置为pil就好

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个默认值为None,是用户可以不用管的意思,同时建立和get_image_backend的联系。直接设置为'pil',达不到这样的意思。可以帮忙看看英文表述如何更准确一些

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LielinJiang LielinJiang reopened this Oct 29, 2020
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LielinJiang LielinJiang merged commit fb1e0c9 into PaddlePaddle:develop Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants