Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the version of pybind, test=develop #28284

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

Shixiaowei02
Copy link
Contributor

@Shixiaowei02 Shixiaowei02 commented Oct 28, 2020

PR types

Bug fixes

PR changes

Others

Describe

Pybind v2.2 为 2017 年发布的旧版本,其遗留 bug 需要替换新版本解决,所以升级 Paddle 的依赖。
考虑到兼容性,此次升级选择 branch/v2.4 的最后稳定发布(v2.4.3)。

涉及到本修改的提交:
1、pybind/pybind11#1603 是一个重要修复:解决了 Python 侧错误修改 C++ const STL 引用容器内容,导致无法直接封装 std::vector / std::map 等 STL 容器的关键问题。
2、pybind/pybind11#1186 修复 Python 2.7 上 int 基本类型的兼容性问题:在拷贝 C++ 整型到 Python 时,根据数值范围挑选数值类型,从而将 Python 2/3 的绑定行为统一。
3、pybind/pybind11#1198 修复了 pybind11 函数签名不符合 Python 编码规范的问题:在等号 = 前后添加空格。

由于上述 2、3 修复,导致接口签名文本内容发生变化,触发强制检查:
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Shixiaowei02 Shixiaowei02 force-pushed the dev/pybind_version branch 2 times, most recently from 0df8ea4 to 6f446a4 Compare October 28, 2020 06:46
@luotao1

This comment has been minimized.

@Shixiaowei02 Shixiaowei02 force-pushed the dev/pybind_version branch 2 times, most recently from 8278744 to 7219fa0 Compare October 29, 2020 06:38
@Shixiaowei02 Shixiaowei02 force-pushed the dev/pybind_version branch 2 times, most recently from c0ff958 to abe64e2 Compare October 29, 2020 07:34
@Shixiaowei02 Shixiaowei02 force-pushed the dev/pybind_version branch 2 times, most recently from ff40164 to 51cae84 Compare October 29, 2020 13:06
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit d9b5f12 into PaddlePaddle:develop Oct 30, 2020
zhwesky2010 added a commit that referenced this pull request Nov 2, 2020
@jzhang533 jzhang533 mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants