Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the cmake external cmd, test=develop #28344

Merged
merged 2 commits into from
Nov 4, 2020
Merged

update the cmake external cmd, test=develop #28344

merged 2 commits into from
Nov 4, 2020

Conversation

Shixiaowei02
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

update the cmake external cmd, test=develop

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 previously approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DannyIsFunny
DannyIsFunny approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 0d25d55 into PaddlePaddle:develop Nov 4, 2020
@Shixiaowei02 Shixiaowei02 deleted the dev/pybind_cmake branch November 4, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyIsFunny DannyIsFunny DannyIsFunny approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shixiaowei02 @DannyIsFunny @zhwesky2010