Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance the op_version_registry, test=develop #28347

Merged

Conversation

Shixiaowei02
Copy link
Contributor

@Shixiaowei02 Shixiaowei02 commented Nov 2, 2020

PR types

New features

PR changes

Others

Describe

本提交重构了版本注册器基础数据结构,以同时适配 C++ 和 Python 调用。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch from da8c6e4 to d2c2488 Compare November 2, 2020 07:57
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch from dea0cae to 055dd9e Compare November 2, 2020 08:08
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch from 5449f0b to 4fcd84a Compare November 2, 2020 08:47
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch 3 times, most recently from 94ff994 to d9a5945 Compare November 2, 2020 10:23
Superjomn
Superjomn previously approved these changes Nov 2, 2020
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch from d9a5945 to af3b279 Compare November 2, 2020 10:35
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch 2 times, most recently from fb95442 to ba2f397 Compare November 2, 2020 10:55
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch 2 times, most recently from 92cb780 to 77f96b1 Compare November 2, 2020 12:54
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch 2 times, most recently from 0696ccd to 8f852c2 Compare November 2, 2020 14:29
@Shixiaowei02 Shixiaowei02 force-pushed the dev/ops_version_pybind branch from 8f852c2 to 159cd27 Compare November 2, 2020 14:31
shangzhizhou
shangzhizhou previously approved these changes Nov 3, 2020
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 21a63f6 into PaddlePaddle:develop Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants