Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix softmax unittest float16 random error #28480

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix softmax unittest float16 random error #28480

merged 1 commit into from
Nov 10, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Nov 9, 2020 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

  • 根据单测报错看应该是反向 inplace 时，精度会随机出现问题，怀疑是 dx 重用了 out 的内存导致，因此去除反向时的内存重用。本地在某些维度上可以复现float16的精度问题，去除内存重用后单测可以通过。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 9, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhupengyang zhupengyang requested review from hong19860320 and removed request for hong19860320 November 9, 2020 05:43
@zhupengyang zhupengyang closed this Nov 9, 2020
@zhupengyang zhupengyang reopened this Nov 9, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 9, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 9, 2020
hong19860320
hong19860320 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 47cbf61 into PaddlePaddle:develop Nov 10, 2020
@zhupengyang zhupengyang deleted the softmax branch November 10, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hong19860320 hong19860320 hong19860320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhupengyang @hong19860320