[fleet_executor] Dist model run method Implementation #39194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
FeixLiu
changed the title
FeixLiu
requested review from
wangxicoding and
XieYunshen
and removed request for
XieYunshen
wangxicoding
approved these changes
Jan 25, 2022
| LOG(ERROR) << "No feed ops in the inf program, please check the program."; | ||
| return false; | ||
| } | ||
| if (fetches_.size() == 0) { |
There was a problem hiding this comment.
不fetch的话，结果怎么拿出来？你是说我们之后第一个carrier返回消息的时候fetch在第一个pp stage？
| if (feeds_.size() == 0) { | ||
| LOG(ERROR) << "Feed ops are needed for the first pp stage."; | ||
| return false; | ||
| } else { |
| if (fetches_.size() == 0) { | ||
| LOG(ERROR) << "Fetch op is needed for the last pp stage."; | ||
| return false; | ||
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Dist model run method Implementation