Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unittests for eigh op #39568

Merged
merged 3 commits into from
Feb 24, 2022
Merged

fix unittests for eigh op #39568

merged 3 commits into from
Feb 24, 2022

Conversation

Zjq9409
Copy link
Contributor

@Zjq9409 Zjq9409 commented Feb 15, 2022

PR types

Function optimization

PR changes

OPs

Describe

  1. 在 CUDA 11.6 后 tolerance 修改到 2e-6 之上
  2. Complex 单测构建 Hermitian matrix

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Zjq9409 Zjq9409 mentioned this pull request Feb 15, 2022
Closed
@Zjq9409 Zjq9409 changed the title fix eigh test fix unittests for eigh op Feb 15, 2022
@zlsh80826
Copy link
Collaborator

LGTM

@JamesLim-sy
Copy link
Contributor

Will tolerance extension of eigh OP do harm to the accuracy while trainning model with this OP in CUDA 11.6.

@zlsh80826
Copy link
Collaborator

@JamesLim-sy
We tested all of Paddle's unit tests on CUDA 11.6 and there is no failure is caused by increasing this tolerance.

@JamesLim-sy
Copy link
Contributor

@JamesLim-sy We tested all of Paddle's unit tests on CUDA 11.6 and there is no failure is caused by increasing this tolerance.

Roger that.

JamesLim-sy
JamesLim-sy approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZzSean
ZzSean approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，PR里补充下提升tolerance的原因吧

@ZzSean ZzSean merged commit 539fb0d into PaddlePaddle:develop Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzSean ZzSean ZzSean approved these changes

@JamesLim-sy JamesLim-sy JamesLim-sy approved these changes

@huangjun12 huangjun12 Awaiting requested review from huangjun12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zjq9409 @zlsh80826 @JamesLim-sy @ZzSean