[phi]migrate increment addmm multinomial cholesky InferShapes to phi #39913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aganlengzi
requested review from
YuanRisheng,
zyfncg,
MingMingShangTian and
chenwhql
chenwhql
previously approved these changes
Feb 25, 2022
| output_dims.push_back(x_dims[0]); | ||
| output_dims.push_back(y_dims[1]); | ||
|
|
||
| out->set_dims(make_ddim(output_dims)); |
There was a problem hiding this comment.
建议infermeta里一并set一下dtype，在原来体系里这边是一个漏洞
| std::vector<T> cumulative_probs(num_categories); | ||
|
|
||
| std::uniform_real_distribution<T> dist(0, 1); | ||
| auto gen_ptr = paddle::framework::DefaultCPUGenerator(); |
There was a problem hiding this comment.
这个相关fluid头文件可以移除，写法也可以改一下，建议把dev_ctx传进来用，不然内部就使用单例了
zyfncg
previously approved these changes
Feb 25, 2022
| "X's shape[-2] = %d and shape[-1] = %d.", | ||
| dims[rank - 2], | ||
| dims[rank - 1])); | ||
| out->set_dims(x.dims()); |
chenwhql
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
1.Migrate increment addmm multinomial cholesky InferShapes to phi
2.Move MultinomialFunctor to paddle/phi/kernels/funcs
3.Make changes for comments in #39858