Support MaskedSelectGrad op with Kernel Primitive API #40617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
AnnaTrainingG
force-pushed
the
Select_Grad
branch
from
71a52f0 to
c8967e6
Compare
xingfeng01
approved these changes
Mar 21, 2022
zkh2016
approved these changes
Mar 21, 2022
xingfeng01
approved these changes
Mar 21, 2022
| typename Functor, | ||
| int VecSize, | ||
| int IsBoundary, | ||
| int IsMaskData> | ||
| int MaskData> |
There was a problem hiding this comment.
建议在下个PR注释里说明下 maskdata =0,1,2 对应的情况
| @@ -123,6 +123,15 @@ __device__ __forceinline__ void WriteData(T* dst, | |||
| dst[i] = src[i]; | |||
| } | |||
| } | |||
|
|
|||
| template <typename T> | |||
There was a problem hiding this comment.
这个和之前的 readdata 可以复用吗 ？
There was a problem hiding this comment.
不可以 这个是线程级别的API
YuanRisheng
reviewed
Mar 21, 2022
| #include "paddle/phi/kernels/masked_select_grad_kernel.h" | ||
|
|
||
| #include "paddle/phi/backends/cpu/cpu_context.h" |
|
|
||
| SelectGradWithPrefixMask<T><<<grid, threads, 0, stream>>>( | ||
| mask_prefix_sum_data, mask_data, input_data, out_data, mask_size); | ||
| auto* out_data = x_grad->mutable_data<T>(dev_ctx.GetPlace()); |
There was a problem hiding this comment.
kernel里分配内存调用新接口：dev_ctx.template Alloc(x_grad)
YuanRisheng
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Support MaskedSelectGrad op with Kernel Primitive API