Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] update pre-commit clang-tidy hook #55894

Merged
merged 1 commit into from
Aug 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions tools/codestyle/clang-tidy.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,13 @@ def main():
parser.add_argument(
'-clang-tidy-binary',
metavar='PATH',
default='clang-tidy-10',
default='clang-tidy-15',
help='path to clang-tidy binary',
)
parser.add_argument(
'-clang-apply-replacements-binary',
metavar='PATH',
default='clang-apply-replacements-10',
default='clang-apply-replacements-15',
help='path to clang-apply-replacements binary',
)
parser.add_argument(
Expand Down Expand Up @@ -412,4 +412,23 @@ def main():


if __name__ == '__main__':
target_version = "15.0.2"
try:
out = subprocess.check_output(['clang-tidy --version'], shell=True)
version = out.decode('utf-8')
if version.find(target_version) == -1:
print(
f"clang-tidy version == {target_version} not found, attempting auto-install...",
file=sys.stderr,
)
subprocess.check_output(
'pip install --no-cache clang-tidy=="15.0.2.1"', shell=True
)
except:
print(
"clang-tidy not found, attempting auto-install...", file=sys.stderr
)
subprocess.check_output(
'pip install --no-cache clang-tidy=="15.0.2.1"', shell=True
)
main()