[tools][clang-tidy] add skip file

[gouzil]

PR types

Others

PR changes

Others

Description

跳过一些.gitignore里面的文件, 跳过编译目录, 跳过.cu后缀文件

检查数量从 2991 减少到 2220, 减少 771 个

测试的编译选项为

cmake .. -DCMAKE_BUILD_TYPE=Release -DWITH_GPU=ON \
-DWITH_TESTING=ON -DWITH_COVERAGE=ON \
-DWITH_PYTHON=ON -DPY_VERSION=3.8 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON 

相关链接:

• 赛题四：在飞桨框架中引入 clang-tidy Tracking Issue #54073

[gouzil]

@GreatV 帮忙检查一下

[GreatV]

这里用 with open 会不会好一点

[GreatV]

windows 下会不会把LF替换成CRLF

[GreatV]

可不可以换成这样的写法

        line = line.strip()
        ...
        if line.startswith("#")

[GreatV]

python ./tools/codestyle/clang-tidy.py -p=build -j=10 -clang-tidy-binary=clang-tidy -extra-arg=-Wno-unknown-warning-option -extra-arg=-Wno-pessimizing-move -extra-arg=-Wno-braced-scalar-init -extra-arg=-Wno-deprecated-copy -extra-arg=-Wno-dangling-gsl -extra-arg=-Wno-final-dtor-non-final-class -extra-arg=-Wno-implicit-int-float-conversion -extra-arg=-Wno-inconsistent-missing-override -extra-arg=-Wno-infinite-recursion -extra-arg=-Wno-mismatched-tags  -extra-arg=-Wno-self-assign -extra-arg=-Wno-sign-compare -extra-arg=-Wno-sometimes-uninitialized -extra-arg=-Wno-tautological-overlap-compare -extra-arg=-Wno-unused-const-variable -extra-arg=-Wno-unused-lambda-capture -extra-arg=-Wno-unused-private-field -extra-arg=-Wno-unused-value -extra-arg=-Wno-unused-variable  -extra-arg=-Wno-overloaded-virtual  -extra-arg=-Wno-defaulted-function-deleted  -extra-arg=-Wno-delete-non-abstract-non-virtual-dtor  -extra-arg=-Wno-return-type-c-linkage  > clang-tidy_v2.log  2>&1 

运行完还会有相关报错

Resource filename: /usr/local/lib/python3.11/dist-packages/clang_tidy/data/bin/clang-tidy 
clang-tidy -extra-arg=-Wno-unknown-warning-option -extra-arg=-Wno-pessimizing-move -extra-arg=-Wno-braced-scalar-init -extra-arg=-Wno-deprecated-copy -extra-arg=-Wno-dangling-gsl -extra-arg=-Wno-final-dtor-non-final-class -extra-arg=-Wno-implicit-int-float-conversion -extra-arg=-Wno-inconsistent-missing-override -extra-arg=-Wno-infinite-recursion -extra-arg=-Wno-mismatched-tags -extra-arg=-Wno-self-assign -extra-arg=-Wno-sign-compare -extra-arg=-Wno-sometimes-uninitialized -extra-arg=-Wno-tautological-overlap-compare -extra-arg=-Wno-unused-const-variable -extra-arg=-Wno-unused-lambda-capture -extra-arg=-Wno-unused-private-field -extra-arg=-Wno-unused-value -extra-arg=-Wno-unused-variable -extra-arg=-Wno-overloaded-virtual -extra-arg=-Wno-defaulted-function-deleted -extra-arg=-Wno-delete-non-abstract-non-virtual-dtor -extra-arg=-Wno-return-type-c-linkage -p=build /paddle/paddle/testing/paddle_gtest_main.cc
/paddle/third_party/eigen3/unsupported/Eigen/CXX11/../../../Eigen/Core:70:10: error: 'omp.h' file not found [clang-diagnostic-error]
#include <omp.h>
         ^~~~~~~
Resource filename: /usr/local/lib/python3.11/dist-packages/clang_tidy/data/bin/clang-tidy 
clang-tidy -extra-arg=-Wno-unknown-warning-option -extra-arg=-Wno-pessimizing-move -extra-arg=-Wno-braced-scalar-init -extra-arg=-Wno-deprecated-copy -extra-arg=-Wno-dangling-gsl -extra-arg=-Wno-final-dtor-non-final-class -extra-arg=-Wno-implicit-int-float-conversion -extra-arg=-Wno-inconsistent-missing-override -extra-arg=-Wno-infinite-recursion -extra-arg=-Wno-mismatched-tags -extra-arg=-Wno-self-assign -extra-arg=-Wno-sign-compare -extra-arg=-Wno-sometimes-uninitialized -extra-arg=-Wno-tautological-overlap-compare -extra-arg=-Wno-unused-const-variable -extra-arg=-Wno-unused-lambda-capture -extra-arg=-Wno-unused-private-field -extra-arg=-Wno-unused-value -extra-arg=-Wno-unused-variable -extra-arg=-Wno-overloaded-virtual -extra-arg=-Wno-defaulted-function-deleted -extra-arg=-Wno-delete-non-abstract-non-virtual-dtor -extra-arg=-Wno-return-type-c-linkage -p=build /paddle/paddle/testing/paddle_gtest_main.cc
/paddle/third_party/eigen3/unsupported/Eigen/CXX11/../../../Eigen/Core:70:10: error: 'omp.h' file not found [clang-diagnostic-error]
#include <omp.h>

Resource filename: /usr/local/lib/python3.11/dist-packages/clang_tidy/data/bin/clang-tidy 
clang-tidy -extra-arg=-Wno-unknown-warning-option -extra-arg=-Wno-pessimizing-move -extra-arg=-Wno-braced-scalar-init -extra-arg=-Wno-deprecated-copy -extra-arg=-Wno-dangling-gsl -extra-arg=-Wno-final-dtor-non-final-class -extra-arg=-Wno-implicit-int-float-conversion -extra-arg=-Wno-inconsistent-missing-override -extra-arg=-Wno-infinite-recursion -extra-arg=-Wno-mismatched-tags -extra-arg=-Wno-self-assign -extra-arg=-Wno-sign-compare -extra-arg=-Wno-sometimes-uninitialized -extra-arg=-Wno-tautological-overlap-compare -extra-arg=-Wno-unused-const-variable -extra-arg=-Wno-unused-lambda-capture -extra-arg=-Wno-unused-private-field -extra-arg=-Wno-unused-value -extra-arg=-Wno-unused-variable -extra-arg=-Wno-overloaded-virtual -extra-arg=-Wno-defaulted-function-deleted -extra-arg=-Wno-delete-non-abstract-non-virtual-dtor -extra-arg=-Wno-return-type-c-linkage -p=build /paddle/paddle/phi/kernels/funcs/segment_pooling.cu
error: no such file or directory: 'arch=compute_89,code=sm_89' [clang-diagnostic-error]
error: too many errors emitted, stopping now [clang-diagnostic-error]
error: unknown argument: '-forward-unknown-to-host-compiler' [clang-diagnostic-error]
error: unknown argument: '-gencode' [clang-diagnostic-error]
error: unsupported option '--expt-extended-lambda' [clang-diagnostic-error]
error: unsupported option '--expt-relaxed-constexpr' [clang-diagnostic-error]
/paddle/paddle/phi/kernels/funcs/gather.cu.h:60:7: error: cannot use 'throw' in __global__ function [clang-diagnostic-error]

[gouzil]

运行完还会有相关报错

Done