[NewIR] No.7 Migrate paddle.softmaxinto pir #57415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
看ci的报错，应该是新ir模式的切换导致了动静态图模式的混乱导致了单测的报错，需要在test_softmax_mkldnn_op的TestSoftmaxMKLDNNPrimitivesAlreadyExist.setUp中调用一下paddle.enable_static() |
0x45f
reviewed
Sep 18, 2023
| @@ -1200,7 +1200,7 @@ def softmax(x, axis=-1, dtype=None, name=None): | |||
|
|
|||
| if (dtype is not None) and (not isinstance(dtype, core.VarDesc.VarType)): | |||
Difers
force-pushed
the
mirgate_to_pir
branch
from
f086ac4 to
49cda24
Compare
Difers
force-pushed
the
mirgate_to_pir
branch
from
49cda24 to
577ac42
Compare
0x45f
approved these changes
Sep 22, 2023
Aurelius84
approved these changes
Sep 22, 2023
| if ( | ||
| (dtype is not None) | ||
| and (not isinstance(dtype, core.VarDesc.VarType)) | ||
| and (not isinstance(dtype, core.DataType)) |
There was a problem hiding this comment.
Suggested change
| and (not isinstance(dtype, core.DataType)) | |
| and (not isinstance(dtype, (core.DataType, core.VarDesc.VarType))) |
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
No.7 Migrate paddle.softmax into pir