Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto parallel] add embedding backward spmd rules #59003

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

cxxly
Copy link
Contributor

@cxxly cxxly commented Nov 14, 2023

PR types

New features

PR changes

Others

Description

Pcard-73145

  • add embedding backward spmd rules
  • fix embedding_grad custom api bugs

@cxxly cxxly force-pushed the spmd_embedding branch 5 times, most recently from c5b1b9a to 57cf7f6 Compare November 21, 2023 04:53
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for embedding_grad_impl

@cxxly cxxly force-pushed the spmd_embedding branch 3 times, most recently from 10cafff to 94819dc Compare November 22, 2023 11:13
@liuzhenhai93 liuzhenhai93 self-requested a review November 23, 2023 02:26
Copy link
Contributor

@liuzhenhai93 liuzhenhai93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxxly cxxly force-pushed the spmd_embedding branch 3 times, most recently from e855108 to ba21d6c Compare November 28, 2023 07:28
@cxxly cxxly merged commit 7331bf9 into PaddlePaddle:develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants