-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.71、186、203、215】 Migrate paddle.fill_diagonal_tensor,roll,shard_index,strided_slice into pir #59091
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该文件下的 _fill_diagonal_tensor_impl
貌似没有适配?该函数是 fill_diagonal_tensor
的实现。需要注意的是:
fill_diagonal_tensor
: 静态图和动态图都可以运行
fill_diagonal_tensor_
: 只有动态图能运行
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
麻烦 merge 一下最新的 develop 分支,然后解决一下冲突 ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill_diagonal_tensor, roll, strided_slice 没问题。shard_index
在 test/legacy_test/test_shard_index_op.py
下对 shard_index 的 pir 单测基本都是设置了 lod 输入,可以先跳过,然后在 pr 描述里写上 "shard_index 的 pir 单测设置了 lod 输入,暂不支持,单测覆盖率 0/4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…or,roll,shard_index,strided_slice into pir (PaddlePaddle#59091)
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
No.71 将
paddle.Tensor.fill_diagonal_tensor
迁移升级至 pir,并更新单测,单测覆盖率:5/5。No.186 将
paddle.Tensor.roll
迁移升级至 pir,并更新单测,单测覆盖率:10/10。No.201 将
paddle.Tensor.shard_index
迁移升级至 pir,shard_index 的 pir 单测设置了 lod 输入,暂不支持,单测覆盖率 0/4No.215 将
paddle.Tensor.strided_slice
迁移升级至 pir,并更新单测,单测覆盖率:31/31。