Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.71、186、203、215】 Migrate paddle.fill_diagonal_tensor,roll,shard_index,strided_slice into pir #59091

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 17, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级

No.71 将 paddle.Tensor.fill_diagonal_tensor 迁移升级至 pir,并更新单测,单测覆盖率:5/5。

No.186 将 paddle.Tensor.roll 迁移升级至 pir,并更新单测,单测覆盖率:10/10。
No.201 将 paddle.Tensor.shard_index 迁移升级至 pir,shard_index 的 pir 单测设置了 lod 输入,暂不支持,单测覆盖率 0/4
No.215 将 paddle.Tensor.strided_slice 迁移升级至 pir,并更新单测,单测覆盖率:31/31。

Copy link

paddle-bot bot commented Nov 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 17, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 17, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该文件下的 _fill_diagonal_tensor_impl 貌似没有适配?该函数是 fill_diagonal_tensor 的实现。需要注意的是:
fill_diagonal_tensor: 静态图和动态图都可以运行
fill_diagonal_tensor_ : 只有动态图能运行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@MarioLulab
Copy link
Contributor

麻烦 merge 一下最新的 develop 分支,然后解决一下冲突 ~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fill_diagonal_tensor, roll, strided_slice 没问题。shard_index
test/legacy_test/test_shard_index_op.py 下对 shard_index 的 pir 单测基本都是设置了 lod 输入,可以先跳过,然后在 pr 描述里写上 "shard_index 的 pir 单测设置了 lod 输入,暂不支持,单测覆盖率 0/4"

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 2499332 into PaddlePaddle:develop Nov 23, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@enkilee enkilee deleted the pir-api-71-and-so-on branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants