Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR+CINN]Adjust GroupOps into natural Order in BuildCInnPass #59255

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Nov 22, 2023

PR types

Function optimization

PR changes

Others

Description

Pcard-67164

对于一个Program 中的算子: A → B → C,经过CinnSubgraphDetector 之后得到的groups中算子是逆序的,即 C → B → A,存在如下问题:

  • 不符合直觉,下游逻辑都需要按照逆序来处理,不利于迭代维护
  • 可能有BUG,当所有的ops都属于一个group,此时解析outputs时却按照了自然序来解析的

故此PR将Group中的ops顺序调整为自然序,即 A → B → C,提高可维护性

修复前:
FDB23AF00B15B223EB6FB54EA9CB6B2F
修复后:
8c7bb05951c827493a39533b225faf96

Copy link

paddle-bot bot commented Nov 22, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aurelius84 Aurelius84 merged commit 9eaa46a into PaddlePaddle:develop Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants