Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] add vjp interface for if_op #59321

Merged
merged 1 commit into from
Nov 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions paddle/fluid/pir/dialect/operator/ir/control_flow_op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
paddle::dialect::IfOp, paddle::dialect::WhileOp
#else
#include "paddle/fluid/pir/dialect/operator/ir/control_flow_op.h"
#include "paddle/fluid/pir/dialect/operator/ir/api_builder.h"

#include "paddle/phi/core/enforce.h"
#include "paddle/pir/core/builder.h"
Expand Down Expand Up @@ -182,6 +183,45 @@ void IfOp::VerifyRegion() {
}
}

std::vector<std::vector<pir::OpResult>> IfOp::Vjp(
pir::Operation *op,
const std::vector<std::vector<pir::Value>> &inputs_,
const std::vector<std::vector<pir::OpResult>> &outputs,
const std::vector<std::vector<pir::Value>> &out_grads,
const std::vector<std::vector<bool>> &stop_gradients) {
PADDLE_ENFORCE_EQ(
inputs_.size() == 1u && inputs_[0].size() >= 1u,
1u,
phi::errors::InvalidArgument(
"if op's inputs size should be 1, but now is %d.", inputs_.size()));

VLOG(6) << "Prepare inputs for if_grad";
auto cond_val = inputs_[0][0];
VLOG(6) << "Prepare attributes for if_grad";

VLOG(6) << "Prepare outputs for if_grad";

std::vector<pir::Type> output_types;
for (size_t i = 0; i < inputs_[0].size(); ++i) {
if (!stop_gradients[0][i]) {
output_types.push_back(inputs_[0][i].type());
}
}

auto if_grad = ApiBuilder::Instance().GetBuilder()->Build<IfOp>(
cond_val, std::move(output_types));

std::vector<std::vector<pir::OpResult>> res{
std::vector<pir::OpResult>(inputs_[0].size())};

for (size_t i = 0, j = 0; i < inputs_[0].size(); ++i) {
if (!stop_gradients[0][i]) {
res[0][i] = if_grad->result(j++);
}
}
return res;
}

void WhileOp::Build(pir::Builder &builder, // NOLINT
pir::OperationArgument &argument, // NOLINT
pir::Value cond,
Expand Down
10 changes: 9 additions & 1 deletion paddle/fluid/pir/dialect/operator/ir/control_flow_op.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
#pragma once
#include <vector>

#include "paddle/fluid/pir/dialect/operator/interface/vjp.h"
#include "paddle/pir/core/op_base.h"

namespace paddle {
namespace dialect {

class IfOp : public pir::Op<IfOp> {
class IfOp : public pir::Op<IfOp, VjpInterface> {
public:
using Op::Op;
static const char *name() { return "pd_op.if"; }
Expand All @@ -45,6 +46,13 @@ class IfOp : public pir::Op<IfOp> {
void Print(pir::IrPrinter &printer); // NOLINT
void VerifySig();
void VerifyRegion();

static std::vector<std::vector<pir::OpResult>> Vjp(
pir::Operation *op,
const std::vector<std::vector<pir::Value>> &inputs_,
const std::vector<std::vector<pir::OpResult>> &outputs,
const std::vector<std::vector<pir::Value>> &out_grads,
const std::vector<std::vector<bool>> &stop_gradients);
};

///
Expand Down
1 change: 1 addition & 0 deletions paddle/fluid/pybind/control_flow_api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ void BindIfOp(py::module* m) {
if_op.def("true_block", &PyIfOp::true_block, return_value_policy::reference)
.def("false_block", &PyIfOp::false_block, return_value_policy::reference)
.def("update_output", &PyIfOp::UpdateOutput)
.def("as_operation", &PyIfOp::operation, return_value_policy::reference)
.def("results", [](PyIfOp& self) -> py::list {
py::list op_list;
for (uint32_t i = 0; i < self->num_results(); i++) {
Expand Down
59 changes: 45 additions & 14 deletions test/ir/pir/test_if_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import unittest

import paddle
from paddle.base.core import call_vjp, has_vjp
from paddle.base.libpaddle.pir import (
build_pipe_for_block,
get_used_external_value,
Expand All @@ -36,41 +37,71 @@ def false_func():


class TestBuildModuleWithIfOp(unittest.TestCase):
def test_if_with_single_output(self):
def construct_program_with_if(self):
main_program = paddle.static.Program()
startup_program = paddle.static.Program()
with paddle.static.program_guard(main_program, startup_program):
x = paddle.static.data(name="x", shape=[6, 1], dtype="float32")
y = paddle.static.data(name="y", shape=[6, 1], dtype="float32")
out = paddle.static.nn.cond(x < y, lambda: x + y, lambda: x - y)
if_op = out[0].get_defining_op()
paddle.static.nn.cond(x < y, lambda: x + y, lambda: x - y)
return main_program

def test_if_with_single_output(self):
main_program = self.construct_program_with_if()
if_op = main_program.global_block().ops[-1]
self.assertEqual(if_op.name(), "pd_op.if")
self.assertEqual(len(out), 1)
self.assertEqual(len(if_op.results()), 1)
value_list = get_used_external_value(if_op)
print(value_list)
self.assertEqual(len(value_list), 3)
self.assertEqual(value_list[0], if_op.operand_source(0))

def test_if_with_multiple_output(self):
main_program = paddle.static.Program()
startup_program = paddle.static.Program()
with paddle.static.program_guard(main_program, startup_program):
x = paddle.static.data(name="x", shape=[6, 1], dtype="float32")
y = paddle.static.data(name="y", shape=[6, 1], dtype="float32")
pred = paddle.less_than(x=x, y=y, name=None)
out = paddle.static.nn.cond(pred, true_func, false_func)
self.assertEqual(out[0].get_defining_op().name(), "pd_op.if")
main_program = self.construct_program_with_if()
cond_value = main_program.global_block().ops[-1].operand_source(0)
with paddle.pir.core.program_guard(main_program):
paddle.static.nn.cond(cond_value, true_func, false_func)
last_op = main_program.global_block().ops[-1]
out = last_op.results()
self.assertEqual(last_op.name(), "pd_op.if")
self.assertEqual(len(out), 2)
if_op = out[0].get_defining_op().as_if_op()

# check Operaion::as_if_op interface
if_op = last_op.as_if_op()
true_block = if_op.true_block()
self.assertEqual(len(true_block), 3)

# check build_pipe_for_block interface
build_pipe_for_block(true_block)
self.assertEqual(len(true_block), 4)

# check Operaion::blocks interface
block_list = []
for block in out[0].get_defining_op().blocks():
block_list.append(block)
self.assertEqual(len(block_list), 2)
self.assertEqual(block_list[0], true_block)
self.assertEqual(block_list[1], if_op.false_block())

def test_if_op_vjp_interface(self):
main_program = self.construct_program_with_if()
if_op = main_program.global_block().ops[-1]
self.assertEqual(if_op.name(), "pd_op.if")
with paddle.pir.core.program_guard(main_program):
out_grad = paddle.full(shape=[6, 1], dtype='float32', fill_value=3)
if_input = [get_used_external_value(if_op)]
if_input_stop_graditents = [[True, False, False]]
if_output = [if_op.results()]
if_output_grad = [[out_grad]]
self.assertEqual(has_vjp(if_op), True)
grad_outs = call_vjp(
if_op,
if_input,
if_output,
if_output_grad,
if_input_stop_graditents,
)
self.assertEqual(grad_outs[0][0], None)


if __name__ == "__main__":
unittest.main()