Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test for coverage cuda12 #59556

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Disable test for coverage cuda12 #59556

merged 7 commits into from
Dec 5, 2023

Conversation

tianshuo78520a
Copy link
Collaborator

@tianshuo78520a tianshuo78520a commented Nov 30, 2023

PR types

Others

PR changes

Others

Description

CUDA12 单测失败,临时禁用单测
Pcard-67012

@@ -242,3 +242,7 @@ if(WITH_DISTRIBUTE AND WITH_GPU)
# End of unittests WITH single card WITHOUT timeout

endif()

if(WITH_COVERAGE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该把在这个之前加一下判断条件
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -479,3 +479,7 @@ if((WITH_ROCM OR WITH_GPU) AND (LINUX))
endif()
add_subdirectory(fleet)
add_subdirectory(multinode)

if(WITH_COVERAGE)
list(REMOVE_ITEM TEST_OPS test_collective_reduce_scatter_api)
Copy link
Contributor

@XieYunshen XieYunshen Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断条件里面加一个NOT WITH_COVERAGE
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

XieYunshen
XieYunshen previously approved these changes Dec 1, 2023
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit da1f7d0 into PaddlePaddle:develop Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants