-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR OpTest Fix No.38】 fix test_semi_auto_parallel_c_cross_entropy #59893
【PIR OpTest Fix No.38】 fix test_semi_auto_parallel_c_cross_entropy #59893
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@@ -267,6 +267,7 @@ test_seed_op | |||
test_segment_ops | |||
test_segment_ops_static_build | |||
test_selu_op | |||
test_semi_auto_parallel_c_cross_entropy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加这个没用吧,这个单测没继承OpTest呀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加这个没用吧,这个单测没继承OpTest呀
确实,之后删掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对third_party/flashattn的修改要revert掉
好的 |
This reverts commit 75b3605.
261fe2f
to
c438f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- op: c_softmax_with_cross_entropy | ||
args: (Tensor logits, Tensor label, int64_t ignore_index=-100, int ring_id=0, int rank=0, int nranks=0) | ||
output: Tensor(softmax), Tensor(loss) | ||
infer_meta: | ||
func : CSoftmaxWithCrossEntropyInferMeta | ||
kernel: | ||
func: c_softmax_with_cross_entropy | ||
data_type : logits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不需要配置backward吗?
…addlePaddle#59893) * register c_softmax * register c_softmax * Update ops_backward.yaml * Update utils.cc * add test_semi_auto_parallel_c_cross_entropy to whitelist * Revert "add test_semi_auto_parallel_c_cross_entropy to whitelist" This reverts commit 75b3605. * add pit test * Update ops.yaml
PR types
Others
PR changes
Others
Description
PIR Op单测修复
修复单测
test_semi_auto_parallel_c_cross_entropy
修复后打开
FLAGS_enable_pir_in_executor
单测是否通过:是