Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CINN]Add InferSymbolicShape of fpn ops #63947

Merged
merged 8 commits into from
May 9, 2024
Merged

[CINN]Add InferSymbolicShape of fpn ops #63947

merged 8 commits into from
May 9, 2024

Conversation

yulangz
Copy link
Contributor

@yulangz yulangz commented Apr 28, 2024 •
edited
Loading

PR Category

CINN

PR Types

Bug fixes

Description

Add DistributeFpnProposalsOpInferSymbolicShape;
Add RoiAlignOpInferSymbolicShape;
fix GatherOpInferSymbolicShape when axis input is tensor;

yulangz added 2 commits April 28, 2024 09:06
@yulangz
Add DistributeFpnProposalsOpInferSymbolicShape;
43f3b2d 
Add RoiAlignOpInferSymbolicShape;
fix GatherOpInferSymbolicShape when axis input is tensor;
fix Expr set_type implementation of derived class;
@yulangz
Merge branch 'develop' into add_fpn_infer_symbolic_shape
0c1c8f1
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 28, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 28, 2024
@yulangz
Copy link
Contributor Author

yulangz commented Apr 28, 2024

对应单测：
layercase/sublayer1000/Det_cases/cascade_rcnn_cascade_mask_rcnn_r50_vd_fpn_ssld_1x_coco/SIR_145.py layercase/sublayer1000/Det_cases/mask_rcnn_mask_rcnn_r101_fpn_1x_coco/SIR_106.py layercase/sublayer1000/Det_cases/mask_rcnn_mask_rcnn_r50_fpn_1x_coco/SIR_106.py layercase/sublayer1000/Det_cases/mask_rcnn_mask_rcnn_r50_fpn_2x_coco/SIR_109.py layercase/sublayer1000/Det_cases/mask_rcnn_mask_rcnn_x101_vd_64x4d_fpn_1x_coco/SIR_108.py layercase/sublayer1000/Det_cases/mask_rcnn_mask_rcnn_x101_vd_64x4d_fpn_2x_coco/SIR_108.py layercase/sublayer1000/Det_cases/res2net_mask_rcnn_res2net50_vd_26w_4s_fpn_2x_coco/SIR_132.py

目前还存在与 Gather 算子实现相关的问题，报错如下：
image

由于 Gather 是子图的最后一个步骤，如果屏蔽掉 Gather，所有的输出都是正确的，如下所示：
image

@yulangz yulangz force-pushed the add_fpn_infer_symbolic_shape branch from 66c4959 to 1f5dfc9 Compare May 8, 2024 06:57
Aurelius84
Aurelius84 previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

heavyrain-lzy
heavyrain-lzy previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for YAML

@yulangz yulangz dismissed stale reviews from heavyrain-lzy and Aurelius84 via f1d2dee May 8, 2024 13:16
@Aurelius84 Aurelius84 merged commit 06dacf0 into PaddlePaddle:develop May 9, 2024
31 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 10, 2024
@yulangz @co63oc
[CINN]Add InferSymbolicShape of fpn ops (PaddlePaddle#63947)
538c655 
* Add DistributeFpnProposalsOpInferSymbolicShape;
Add RoiAlignOpInferSymbolicShape;
fix GatherOpInferSymbolicShape when axis input is tensor;
fix Expr set_type implementation of derived class;

* fix

* change shape_analysis to infer_context

* fix
@yulangz yulangz mentioned this pull request May 10, 2024
Closed
29 tasks
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 11, 2024
@yulangz @co63oc
[CINN]Add InferSymbolicShape of fpn ops (PaddlePaddle#63947)
f4caced 
* Add DistributeFpnProposalsOpInferSymbolicShape;
Add RoiAlignOpInferSymbolicShape;
fix GatherOpInferSymbolicShape when axis input is tensor;
fix Expr set_type implementation of derived class;

* fix

* change shape_analysis to infer_context

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hongqing-work Hongqing-work Hongqing-work left review comments

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@heavyrain-lzy heavyrain-lzy heavyrain-lzy left review comments

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yulangz @Aurelius84 @heavyrain-lzy @Hongqing-work