Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine device context #6433

Merged
merged 24 commits into from
Dec 12, 2017
Merged

Refine device context #6433

merged 24 commits into from
Dec 12, 2017

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Dec 9, 2017 •
edited
Loading

Fix #6415
For more background, please refer to #6403

There are mainly following fixes:

  • take DeviceContext as the template parameter of math functors and OpKernel instead of Place
  • remove eigen_device interface in base class DeviceContext
  • remove GetEigenDevice interface in ExecutionContext and base class DeviceContext
  • remove unused platform::EigenDeviceConverter
  • rename REGISTER_OP_GPU_KERNEL to REGISTER_OP_CUDA_KERNEL
  • rename USE_GPU_ONLY_OP to USE_CUDA_ONLY_OP

@QiJune QiJune force-pushed the refine_DeviceContext2 branch from c247a9b to 57f383c Compare December 10, 2017 03:54
@tonyyang-svail
Copy link

@QiJune could you also update the docs? doc/howto/dev/new_op_cn.md and doc/howto/dev/new_op_en.md

@QiJune
Copy link
Member Author

QiJune commented Dec 12, 2017

@tonyyang-svail I will update the doc in next PR. This PR is too big.

tonyyang-svail
tonyyang-svail approved these changes Dec 12, 2017
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@QiJune QiJune merged commit 61ec0b9 into PaddlePaddle:develop Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@qingqing01 qingqing01 Awaiting requested review from qingqing01

@chengduoZH chengduoZH Awaiting requested review from chengduoZH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to refine the design of DeviceContext
2 participants
@QiJune @tonyyang-svail