Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPSIG] Add meeting agenda in ppsigs #557

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

KevinLi43
Copy link
Contributor

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ KevinLi43
❌ lihaoxuan04


lihaoxuan04 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

onecatcn
onecatcn previously approved these changes Jun 28, 2023
Copy link
Collaborator

@onecatcn onecatcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以根据上述修改,并进一步补充参与人的list

@shiyutang shiyutang changed the title Add meeting agenda in ppsigs [PPSIG] Add meeting agenda in ppsigs Jul 3, 2023
Copy link
Contributor

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两处细节~

@shiyutang
Copy link
Contributor

ppsigs/meetings/2023/2023-07-04-meeting-agenda.md需要修改成0705,另外minutes可以不用增加,我已经增加并合入了~

Copy link
Contributor

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyutang shiyutang merged commit 84a7a20 into PaddlePaddle:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants