Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] 新增ignore_module API的中文文档 #5571

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

huajiao-hjyp
Copy link
Collaborator

@huajiao-hjyp huajiao-hjyp commented Jan 9, 2023

动转静功能下新增 ignore_module API的中文文档

PADDLEPADDLE_PR=49485

@paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5571.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview 也要加一下索引~(https://github.com/PaddlePaddle/docs/blob/develop/docs/api/paddle/jit/Overview_cn.rst?plain=1#L28

最好在 api_label 也加一下~以确保英文索引正常~(https://github.com/PaddlePaddle/docs/blob/develop/docs/api/api_label#L346

现在 CI 挂了是因为 COPY-FROM 失败造成的,我在 PR 描述里加上了 PADDLEPADDLE_PR=49485,之后再跑一下看看咋样~


.. py:function:: paddle.jit.ignore_module(modules)

本接口可以自定义增加动转静过程中忽略转写的模块,目前默认忽略转写的模块有 collections, pdb, copy, inspect, re, numpy, logging, six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
本接口可以自定义增加动转静过程中忽略转写的模块,目前默认忽略转写的模块有 collections, pdb, copy, inspect, re, numpy, logging, six
本接口可以自定义增加动转静过程中忽略转写的模块,目前默认忽略转写的模块有 collectionspdbcopyinspect、re、numpyloggingsix

@Ligoml
Copy link
Collaborator

Ligoml commented Jan 10, 2023

Overview 也要加一下索引~(https://github.com/PaddlePaddle/docs/blob/develop/docs/api/paddle/jit/Overview_cn.rst?plain=1#L28

最好在 api_label 也加一下~以确保英文索引正常~(https://github.com/PaddlePaddle/docs/blob/develop/docs/api/api_label#L346

现在 CI 挂了是因为 COPY-FROM 失败造成的,我在 PR 描述里加上了 PADDLEPADDLE_PR=49485,之后再跑一下看看咋样~

明天重跑CI就可以了,这条检查的逻辑是抓取最新的whl包编译文档,因为paddle的whl包是每天更新的,所以今天合入的pr无法被编进文档中,就会挂掉,明天就好了
另外 @Tomoko-hjf 可以参考 @SigureMo 的建议完善一下文档细节~

Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@Ligoml Ligoml merged commit 2f1ba2e into PaddlePaddle:develop Jan 11, 2023
@huajiao-hjyp huajiao-hjyp deleted the ignore-modules branch March 6, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants