-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init test framework #541
init test framework #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change the grammar?
Please dismiss the previous Approve, it's a mistake click. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bunch of rephrasing comments, maybe once the other reviewers approve this PR, we can merge this and I can create a new PR with the suggested rephrasing and you folks can review it. I was trying to point them out here, but there are quite a few of them, so I stopped at two.
@@ -0,0 +1,81 @@ | |||
# Models continuous integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Models continuous integration" => "Continuous integration for models"
This framework aims to add continuous integration to formal models based on PaddlePaddle. | ||
|
||
## Background | ||
Currently, there are two official repositories that provide open source models based on PaddlePaddle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"based on" => "using"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a supplement:
We should make standards for feeding arguments to model trainning.
e.g. :save_dir_path of 'generate_chinese_poetry' is different with model_save_dir of 'text_classification'.
Furthermore, building models bank as a python module may be helpful for implementing test framework conveniently. After pip install paddle-models-versionxxx
we can use models as below:
import paddle.models
model = models.text_classification()
arguments = {'batch_size': 128, 'train_passes':500 ...}
model.setArgs(arguments)
model.train()
fixes: #521